Fixes for "international" issues I found #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dzacarias
commented
Oct 2, 2011
dzacarias
commented
- I'm on GMT (Lisbon, Portugal) and the option selection code didn't work when there were 0 hours difference from GMT (no options have that text)
- Garmin Connect seems to log us out after posting around 25 runs. Added code to catch the exception, log back in and carry on.
- I have different date, time and number formats than the defaults. Added code to get the user's preferences from the settings page and format those types accordingly. Garmin's site expects the input to follow the user's settings.
* I'm on GMT and the option selection code didn't work when there were 0 hours difference from GMT (no options have that text) * Garmin seems to log us out after posting some runs. Added code to catch the exception, log back in and carry on. * I have different date, time and number formats than the defaults. Added code to get the user's preferences from the settings page and format those types accordingly. Garmin's site expects the input to follow the user's settings.
|
This looks sharp. Merging. Thanks! |
holman
added a commit
that referenced
this pull request
Oct 12, 2011
Fixes for "international" issues I found
|
There's a new version of fatigue on RubyGems now, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.